Update autocontrast #2317
Merged
Update autocontrast #2317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThe pull request modifies the auto contrast function to allow for a cutoff and ignore parameters, and adds a method parameter to select between 'cdf' and 'pil' methods. It also adds new tests for the auto contrast function. Class diagram for updated AutoContrast transformclassDiagram
class AutoContrast {
+float cutoff
+int|None ignore
+str method
+float p
+__init__(cutoff: float, ignore: int|None, method: str, p: float)
+apply(img: ndarray) -> ndarray
+apply_to_images(images: ndarray) -> ndarray
+apply_to_volume(volume: ndarray) -> ndarray
+apply_to_volumes(volumes: ndarray) -> ndarray
+get_transform_init_args_names() -> tuple
}
note for AutoContrast "New parameters added:
- cutoff: % of pixels to exclude
- ignore: value to preserve
- method: 'cdf' or 'pil'"
Flow diagram for enhanced auto_contrast functionflowchart TD
A[Start auto_contrast] --> B{Check image channels}
B -->|Multi-channel| C[Pre-compute histograms]
B -->|Single channel| D[Compute histogram]
C --> E[Process each channel]
D --> E
E --> F{Check ignore value}
F -->|Has ignore value| G[Skip ignored channel]
F -->|No ignore value| H[Get histogram bounds]
H --> I{Check cutoff}
I -->|Has cutoff| J[Calculate bounds with cutoff]
I -->|No cutoff| K[Use min/max non-zero values]
J --> L[Create contrast LUT]
K --> L
L --> M{Select method}
M -->|CDF method| N[Apply CDF-based scaling]
M -->|PIL method| O[Apply linear scaling]
N --> P[Apply LUT to channel]
O --> P
P --> Q[Return enhanced image]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @ternaus - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Improve the
auto_contrastfunction by adding parameters for cutoff, ignore value, and method selection. Add tests for the new functionality and helper functions.New Features:
cutoffparameter to control the percentage of pixels to cut off from the histogram edges.Tests:
auto_contrastfunction, including edge cases and numerical stability.